[4.x] Use 'configure' permission for configuring navs #9961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonvarga
requested changes
Apr 26, 2024
|
On second thought and after trying it, you're right. IMO this is just a fix. The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently every user that is allowed to edit a nav (meaning adding new entries etc.) is also allowed to configure a nav (meaning changing the name, max depths etc.). This PR changes this behaviour to only allow the latter with the added
configurepolicy, which resolves to theconfigure navspermission.I don't know if that would be considered a breaking change. It feels like this should be a fix, as the behaviour for e. g. collections works like that, however, I can see that it actually changes something that might be used in a certain way for some people. If you consider it breaking, maybe it might be better to add this to 5.x.